postmarketos-base-ui: enable USB tethering v2

USB tethering support

Enable USB tethering on postmarketOS' setup with unudhpcd and NetworkManager. Users can share their WWAN or WiFi iface of their phones with desktops/laptops over USB while still accessing the phone over USB with SSH.

What is USB tethering?

Several Android/iOS phones allow you to share your WiFi or WWAN interface to a connected laptop/desktop over USB. This is similar to a WiFi hotspot, but over USB. As an user, you benefit from lower power consumption, no need to secure your hotspot, and you can share your WiFi connection as well. Bonus: US carriers cannot see that we're tethering and charge for this feature like on Android/iOS as we don't report this to the carrier like Android/iOS OS does :)

How does it work?

NetworkManager supports tethering out-of-the-box under the IPv4/IPv6 method shared which spawns dnsmasq for DHCP requests from the connected client and DNS forwarding from the client to the DNS server configured on the phone. However, this heavily conflicts with postmarketOS setup in its initfs as unudhcpd also acts as DHCP server. Moreover, by default, NetworkManager does not manage USB Ethernet gadgets like we create in initfs.

This MR solves these problems as followed:

1. Expand NetworkManager with a reapply dispatcher action so we can add on the iface changes that are applied when a NetworkManager connection profile is changed. After a change to the connection profile, a reapply job needs to be executed which triggers the dispatcher action.
2. Execute a dispatcher script when the connection profile is reapplied:

• manual mode which is like in initfs, IP is static set to 172.16.42.1 for the phone, 172.16.42.2 for the connected client, iface becomes managed by NetworkManager and unudhcpd handles DHCP requests. If unudhcpd is not running, it gets spawned.
• shared mode which is USB tethering, NetworkManager spawns dnsmasq and uses IP is 172.16.42.1 for the phone and a DHCP server for the connected client. The whole available range is used. If unudhcpd is running, it gets killed to avoid conflicts with dnsmasq. NetworkManager will also arrange the necessary configs so IP forwarding is enabled in the kernel and firewall. These configs are removed when tethering is disabled again.

When the mode is changed, UDC of the gadget is reactivated to trigger a disconnect/connect event on the connected client. This way, we ensure that the client performs a DHCP request to request an IP from either unudhcpd or dnsmasq, depending on the mode. The script logs with logger to syslog under the tag nm-tethering.

No matter which mode is active, SSH login over USB still works as the phone still uses the same IP 172.16.42.1.

How to test this?

Checkout the branch and build it with pmbootstrap. mrtest does not work as the CI times out, CI builds skipped.

To use this feature:

1. Connect your phone over USB to your desktop.
2. On the phone, open Settings
3. Go to the Network panel tab.
4. You should see 1 wired connection at the top, tab the edit settings button (gear)
5. An old panel opens which doesn't fit your screen (use Phosh Mobile Settings to enable scale-to-fit for this panel only, it will be shown in the list of active apps).
6. Go to the IPv4 tab.
7. Select 'Shared to other computers' and tab the Apply button in the right corner.

NM should now launch its own dnsmasq instance, configure the firewall to allow internet sharing over usb0. It will trigger a script to re-establish the USB ethernet connection with the desktop. This way, the desktop will get an IP in the 10.X.X.X range and also a DNS server to which it can send DNS queries for this connection. Normally, you should be able to access the Web over usb0 now if you have WiFi or WWAN turned ON on the phone.

TODOs

• Once unplugged, it does not autoconnect anymore when plugged in again. NetworkManager blocks everything until the user manually enables the USB Ethernet device in GNOME Settings. This is resolved by setting the connection autoconnect property to true.
• On each boot, NetworkManager creates a new connection profile for usb0.
• GNOME Settings does not seem to perform a reapply of the connection on the iface when pressing 'Apply' in the connection setting UI.
• dnsane support (!3805 (closed))?

Draft until these TODOs are addressed or a solution if on the way for them.

Upstream

• NetworkManager MR 1311
• NetworkManager dnsmasq fix MR 43470
• GNOME Settings reapply on device fix MR 1642
• NetworkManager upgrade to 1.42.0 MR 44105
• GNOME Settings reapply patch backported to Alpine MR 44146
• dnsmasq missing pre-install script MR 44152

Issues & merge requests

Fixes #1904 (moved)
Fixes unudhcpd#1 (moved)
Contributes to #1518
Superseeds !3301 (closed)

Tested on Plasma Mobile, but Settings cannot set the connection to shared mode and back. So only the CLI way is available there.

CC: @craftyguy

temp/gnome-control-center/0001-network-reapply-connection-on-device.patch

+From 50e93872e05b05b311e78c40e13dc197121464f6 Mon Sep 17 00:00:00 2001
+From: Dylan Van Assche <me@dylanvanassche.be>
+Date: Mon, 23 Jan 2023 14:46:31 +0100
+Subject: [PATCH] network: reapply connection on device
+
+Changing an active connection applies the changes onto the
+NetworkManager connection, but not on the device. This is because
+NetworkManager clones the connection when it is applied on a device.
+This behavior is expected and documented in the NetworkManager
+documentation [1]. To effectively apply the connection changes onto a
+device, a reapply operation must be performed. This will make NetworkManager
+apply the new connection onto the active device without having to
+disable and re-enable the device.
+
+Perform this reapply operation when the Apply button is pressed in the
+Connection Editor so the changes effectively propagate to the network
+device.
+
+[1] https://networkmanager.dev/docs/api/1.32.10/gdbus-org.freedesktop.NetworkManager.Device.html#gdbus-method-org-freedesktop-NetworkManager-Device.Reapply
+---
+ .../connection-editor/net-connection-editor.c | 31 ++++++++++++++++---
+ 1 file changed, 27 insertions(+), 4 deletions(-)
+
+diff --git a/panels/network/connection-editor/net-connection-editor.c b/panels/network/connection-editor/net-connection-editor.c
+index 03d9fcac0..d567bf1b0 100644
+--- a/panels/network/connection-editor/net-connection-editor.c
++++ b/panels/network/connection-editor/net-connection-editor.c
+@@ -201,6 +201,25 @@ update_complete (NetConnectionEditor *self,
+         g_signal_emit (self, signals[DONE], 0, success);
+ }
+ 
++static void
++device_reapply_cb (GObject            *source_object,
++                   GAsyncResult       *res,
++                   gpointer            user_data)
++{
++        NetConnectionEditor *self;
++        g_autoptr(GError) error = NULL;
++        gboolean success = TRUE;
++
++        if (!nm_device_reapply_finish (self->device, res, &error)) {
++                g_warning ("Failed to reapply changes on device: %s", error->message);
++                success = FALSE;
++        }
++
++        self = user_data;
++
++        update_complete (self, success);
++}
++
+ static void
+ updated_connection_cb (GObject            *source_object,
+                        GAsyncResult       *res,
+@@ -214,13 +233,15 @@ updated_connection_cb (GObject            *source_object,
+                                                          res, &error)) {
+                 g_warning ("Failed to commit changes: %s", error->message);
+                 success = FALSE;
+-                //return; FIXME return if cancelled
++                update_complete (self, success);
++                return;
+         }
+ 
+         nm_connection_clear_secrets (NM_CONNECTION (source_object));
+ 
+         self = user_data;
+-        update_complete (self, success);
++        nm_device_reapply_async (self->device, NM_CONNECTION (self->orig_connection),
++                                 0, 0, NULL, device_reapply_cb, self);
+ }
+ 
+ static void
+@@ -236,11 +257,13 @@ added_connection_cb (GObject            *source_object,
+                 g_warning ("Failed to add connection: %s", error->message);
+                 success = FALSE;
+                 /* Leave the editor open */
+-                // return; FIXME return if cancelled
++                update_complete (self, success);
++                return;
+         }
+ 
+         self = user_data;
+-        update_complete (self, success);
++        nm_device_reapply_async (self->device, NM_CONNECTION (self->orig_connection),
++                                 0, 0, NULL, device_reapply_cb, self);
+ }
+ 
+ static void
+-- 
+2.39.0
+