Skip to content

Draft: linux-postmarketos-*: Enable more LEDs triggers

Jakko requested to merge jakko/pmaports:leds_trigger_modules into master

The LEDs triggers can be used to control the behaviour of LEDs.

Enabled as compiled-in:

  • Enable CONFIG_LEDS_TRIGGER_BACKLIGHT as compiled-in because this one seems especially helpful to handle the LEDs of touch buttons.
  • Also CONFIG_LEDS_TRIGGER_CAMERA as compiled-in because probably helpful.
  • CONFIG_LEDS_TRIGGER_CPU because boolean.
  • CONFIG_LEDS_TRIGGER_PANIC because boolean.

Enabled as modules:

  • All others that where not enabled yet (though I didn't change the ones that were already enabled as compiled-in).
  • CONFIG_LEDS_TRIGGER_GPIO depends on GPIOLIB, though this seems to be enabled everywhere.
  • CONFIG_LEDS_TRIGGER_NETDEV depends on NET, should be fine everywhere.
  • CONFIG_LEDS_TRIGGER_TTY depends on TTY, should be fine. (Not availale on qcom-msm8939 and qcom-sdm660 because older kernel versions.)
  • CONFIG_USB_LEDS_TRIGGER_USBPORT (other folder, see below) depends on USB, should be fine. (Not available on stericsson.)

Not enabled:

  • CONFIG_LEDS_TRIGGER_DISK not enabled because of dependency on ATA. (In qcom-sm8150 and rockchip it was already enabled, I didn't change that.)
  • CONFIG_LEDS_TRIGGER_MTD not enabled because of dependency on MTD.
  • CONFIG_LED_TRIGGER_PHY (other folder, see below) not enabled because only available if PHYLIB enabled.
  • CONFIG_NETFILTER_XT_TARGET_LED (other folder, see below) not enabled. Depends on NETFILTER_ADVANCED and I wasn't sure this is available everywhere.

Information on the configs in the LEDs trigger folder: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/trigger/Kconfig?h=v5.14-rc7

Outside of this folder

Information on usage of LEDs triggers see: https://wiki.postmarketos.org/wiki/LEDs#Triggers

The config files were edited manually.

If some of the changes are inappropriate, let me know.

CC Maintainers: @MartijnBraam @ThiagaoPlusPlus @Minecrell @Ultracoolguy @z3ntu @Tooniis @minlexx @calebccff

Edited by Jakko

Merge request reports