Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • pmaports pmaports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 637
    • Issues 637
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 58
    • Merge requests 58
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • postmarketOSpostmarketOS
  • pmaportspmaports
  • Merge requests
  • !1750

feedbackd: Configure haptic feedback per device

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dylan Van Assche requested to merge dylanvanassche/pmaports:feedbackd-config into master Nov 23, 2020
  • Overview 47
  • Commits 1
  • Pipelines 28
  • Changes 2

The default configuration of feedbackd is fine for the Librem5's vibrator but not for the PinePhone's vibrator. I wasn't aware of this problem until I tried out Arch Linux a while back. They use the following config: https://github.com/dreemurrs-embedded/Pine64-Arch/blob/master/PKGBUILDS/phosh/danctnix-phosh-ui-meta/danctnix_feedbackd.json

I ported the configuration over to pmOS and typing is really improved since you get haptic feedback when pressing a key.

As suggested by https://source.puri.sm/Librem5/feedbackd/-/issues/27 and @ollieparanoid, using the device tree to match the right profile is preferred. In case that fails, the environment variable FEEDBACK_THEME is read by feedbackd. This variable contains the patch to the feedback theme to use. If that also fails, the default.json config is used.

As requested by upstream, adding pine64,pinephone to the compatible list in the kernel DTS file. This allows us to use a single configuration file for all hardware revisions of the PinePhone. Furthermore, the device configurations are now packaged separately as feedbackd-device-themes to match upstream.

Upstreaming at https://source.puri.sm/Librem5/feedbackd/-/merge_requests/44 but providing this branch for testing purposes. If all goes well, upstreaming to Alpine!

Edited Dec 26, 2020 by Dylan Van Assche
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feedbackd-config