Skip to content

maemo/libhildon: remove inline from function to enable compiling hildon-desktop on armv7

Bart Ribbers requested to merge armv7 into master

Do note that this is not finished yet. Compiling for most packages works fine, but it breaks on maemo/hildon-desktop (only on armv7) with the following error:

/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_clip_to_alloc'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_hue_bar_dimmed'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_sv_plane'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_h2rgb'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_hue_bar'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_sv_plane_dimmed'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_limited_expose'
collect2: error: ld returned 1 exit status

I've already mentioned this in #maemo-leste, but maybe someone else knows what's wrong.

I decided to go for $arch = "all !x86" instead of $arch = "x86_64 armhf aarch64", as I understood the packages are only broken on x86. Rather than adding all architectures that do work, this makes sure it can be compiled on all architectures except for x86. Also, I believe the $pkgrel doesn't have to be increased as the only thing changed in this packaging is making armv7 compiling possible, which is useless for the other architectures.

Edited by Bart Ribbers

Merge request reports