Skip to content

fix: busy system snapshot detection in physical mode (#605)

Artyom Kartasovrequested to merge
605-physical-mode-snapshot-retention into dle-4-0

Description

Fix busy system snapshot detection in physical mode

Related issue

#605 (closed)

Examples

Initial state

$ zfs list -t snapshot
NAME                                                                              USED  AVAIL     REFER  MOUNTPOINT
test_dblab_pool@snapshot_20250403061908_pre                                       186K      -     23.3M  -
test_dblab_pool@snapshot_20250403085500_pre                                        18K      -     23.4M  -
test_dblab_pool@snapshot_20250403090000_pre                                        18K      -     23.4M  -
test_dblab_pool@snapshot_20250403090500_pre                                        18K      -     23.4M  -
test_dblab_pool@snapshot_20250403095206_pre                                       185K      -     23.4M  -
test_dblab_pool@snapshot_20250403100240_pre                                       193K      -     23.3M  -
test_dblab_pool/branch/main/clone_pre_20250403061908/r0@snapshot_20250403061908     0B      -     23.3M  -
test_dblab_pool/branch/main/clone_pre_20250403085500/r0@snapshot_20250403085500     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403090000/r0@snapshot_20250403090000     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403090500/r0@snapshot_20250403090500     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403095206/r0@snapshot_20250403095207     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403100240/r0@snapshot_20250403100119     0B      -     23.4M  -
test_dblab_pool/branch/main/cvn2j50n9i6s73as3k9g/r0@20250403062503                 52K      -     23.4M  -
test_dblab_pool/branch/main/cvn2kdon9i6s73as3ka0/r0@20250403062722               54.5K      -     23.3M  -
test_dblab_pool/branch/new001@20250403062641                                        1K      -     23.4M  -
$ zfs list -S clones -o name,origin -H -r test_dblab_pool | grep -v -
test_dblab_pool/branch/main/clone_pre_20250403061908/r0	test_dblab_pool@snapshot_20250403061908_pre
test_dblab_pool/branch/main/clone_pre_20250403090500/r0	test_dblab_pool@snapshot_20250403090500_pre
test_dblab_pool/branch/main/clone_pre_20250403095206/r0	test_dblab_pool@snapshot_20250403095206_pre
test_dblab_pool/branch/main/clone_pre_20250403100240/r0	test_dblab_pool@snapshot_20250403100240_pre
test_dblab_pool/branch/main/cvn2j50n9i6s73as3k9g/r0	test_dblab_pool/branch/main/clone_pre_20250403061908/r0@snapshot_20250403061908
test_dblab_pool/branch/main/cvn2kdon9i6s73as3ka0/r0	test_dblab_pool/branch/new001@20250403062641
test_dblab_pool/branch/new001	test_dblab_pool/branch/main/cvn2j50n9i6s73as3k9g/r0@20250403062503
test_dblab_pool/branch/new001/cvn4n38n9i6s73as3kag/r0	test_dblab_pool/branch/new001@20250403062641

After retention cleanup

Retention limit: 3, BUT: test_dblab_pool@snapshot_20250403061908_pre is a basic snapshot for user-defined objects

$ zfs list -t snapshot
NAME                                                                              USED  AVAIL     REFER  MOUNTPOINT
test_dblab_pool@snapshot_20250403061908_pre                                       186K      -     23.3M  -
test_dblab_pool@snapshot_20250403090500_pre                                       186K      -     23.4M  -
test_dblab_pool@snapshot_20250403095206_pre                                       185K      -     23.4M  -
test_dblab_pool@snapshot_20250403100240_pre                                       193K      -     23.3M  -
test_dblab_pool/branch/main/clone_pre_20250403061908/r0@snapshot_20250403061908     0B      -     23.3M  -
test_dblab_pool/branch/main/clone_pre_20250403090500/r0@snapshot_20250403090500     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403095206/r0@snapshot_20250403095207     0B      -     23.4M  -
test_dblab_pool/branch/main/clone_pre_20250403100240/r0@snapshot_20250403100119     0B      -     23.4M  -
test_dblab_pool/branch/main/cvn2j50n9i6s73as3k9g/r0@20250403062503                 52K      -     23.4M  -
test_dblab_pool/branch/main/cvn2kdon9i6s73as3ka0/r0@20250403062722               54.5K      -     23.3M  -
test_dblab_pool/branch/new001@20250403062641                                        1K      -     23.4M  -

Checklist

  • MR description has been reviewed
  • MR changes are functionally tested
  • MR does NOT have API/CLI changes OR there are API/CLI changes and they have been reviewed & DOCS ARE ADJUSTED (reference doc, etc)
  • MR does NOT have UI changes OR there are UI changes and they have been reviewed & UX IS REVIEWED

Closes #605 (closed)

Merge request reports