Complete clone failure due to switch from -p to PG_SERVER_PORT in 3.4.0 rc.8 and above in docker.go
I just upgraded from 3.4.0 rc.6 to rc.9 and all my clones started failing with the following:
postgres.go:109: [ERROR] Currently cannot connect to Postgres: dial unix /var/lib/dblab/dblab_pool/sockets/dblab_clone_6000/.s.PGSQL.6000: connect: no such file or directory
After digging around for several hours, it appears that Postgres in the clone containers is running on port 5432 instead of the desired instance port. As far as I can tell, this is because of the change from 3.4.0 rc.8 to now specify the desired instancePort in docker.go with PG_SERVER_PORT instead of -p. The PG_SERVER_PORT is set within the Docker container, but for some reason the Postgres process is still launching via 5432; I'm not sure how the environment variable is supposed to be picked up. Maybe pg_start.sh needs updating? Or was there was a config change between rc.7 and rc.8 I missed?