Skip to content

Make get_total_download_size return bytes instead of MiB

PopeRigby requested to merge poperigby/portmod:download-size-bytes into master

I was curious, how is this part able to read the file_type and size member variables if they're defined in a subclass? My linter was complaining.

for manifest in manifest_file.entries.values():
    if manifest.file_type == FileType.DIST:
        download_bytes += manifest.size

Also, would you like me to convert the size to KiB or GiB if the file is big or small enough respectively, in portmod.query.display_search_results? Maybe get_total_download_size should just do that.

Merge request reports