Skip to content

Convert symbol of custom system_tag to downcase if it matches the string 'Custom_'

Rey requested to merge TheRey/pokemonsdk:convert_custom_sys_tag into development

MR Description

  • This MR adds a conversion of the name format from the new custom system_tag feature from Studio 2.1.1 to a downcased symbol.
  • The name format will follow this rule: "Custom_NameOfSysTag", so a custom system_tag labeled Aquatic_Grass in Studio will be named "Custom_Aquatic_Grass" in the JSON, and known to PSDK as "custom_aquatic_grass" to follow the naming convention followed until now.
  • Note: this MR only ensure the custom system_tag will be known to PSDK in the right name format and doesn't change anything concerning the initializing of constants and monkey-patching of methods affiliated to System_Tags
  • Note 2: this MR won't impact anything if used with Studio 2.1.0 and will start to work when Studio 2.1.1 will be released

Before testing

  • Make sure you're running Studio 2.1.1 (in dev, currently)
  • In Studio, change the system_tag of a group to Custom and write the name of the System_Tag to use. Make sure to note which group you have modified this way. (ID or db_symbol)

Tests to realize

  • Launch PSDK, then after the conversion process, type data_group(id).system_tag (replace id) in the console: the symbol displayed should be the downcased version of the symbol written in the JSON file of your group.
Edited by Palbolsky

Merge request reports