Skip to content

Enable PSDK to reload the audio output source if it changed

Rey requested to merge TheRey/pokemonsdk:feature/reload-output-source into development

MR Description

  • This MR enables PSDK to output the audio on the right output source if it changed or if the previous audio output source got disconnected for some reason.

Before testing

  • Make sure you have at least two different audio devices ready to use for the test.
  • Please make sure to get the binaries given in the description of !1114 (merged)

Notes to acknowledge before testing

  • The reloading only occurs when a new BGM, BGS, or ME file is newly played.
  • This uses a native function of FMOD. This feature doesn't exist on SFMLAudio, thus the test must be done while using FMOD. You can know if you're using FMOD by typing Object.const_defined?(:FMOD) in your console.
  • This feature of FMOD supposedly only works on Windows, but it shouldn't cause any sort of problem on any other OS. A test on Linux and Mac would be highly appreciated.

Tests to realize

  • Launch PSDK on your first audio device and with FMOD enabled. Change your default output using Windows' sound mixer, and then make PSDK play a BGM/BGS/ME (by walking on another map, or running an event that does so): the audio output should change and the sound should play on the new audio device.
Edited by Zøzo

Merge request reports