Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • P plom
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 621
    • Issues 621
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • plom
  • plom
  • Merge requests
  • !1451

Marker: just update the selected row all the time

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Colin Macdonald requested to merge stale2 into main May 10, 2022
  • Overview 13
  • Commits 5
  • Pipelines 3
  • Changes 1

We had complicated logic about when to update Marker's preview when annotator closes. We got wrong in many cases (Issue #1966 (closed), and Issue #2136 (closed), maybe others). Instead just always update the currently selected row.

If it does not need updating, then no harm done [*].

[*] I think: the interaction here with background uploader if wonky like everything else about bguploader.

Fixes #2136 (closed). Fixes #1966 (closed).


Rename function, sensible docs, log a special case

The docs didn't read right to me: checked and fixed.

Not clear what we should do on unselect: left a todo for that.  For now
it logs.

After I did !1450 (merged), I tried to refactor a bit: this is result. Can be applied after !1450 (merged) or by itself (its got !1450 (merged) commits here too).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: stale2