Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pine64
  • linux
  • Merge requests
  • !39

Draft: Revert "input: touchscreen: goodix: Add support for GT1158"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Tom requested to merge tomfitzhenry/linux:pine64-remove-gt1158 into pine64-kernel-ppp-5.16.y May 23, 2022
  • Overview 0
  • Commits 1
  • Changes 1
  • Marked as Draft until I test this.

This reverts commit 0dd4edb5.

Ideally we'd just remove this commit from the fork. What's a good workflow for this?

Per the DTS[0], PinePhone Pro does not use GT1158. Rather, it uses gt917s which is in the goodix touchscreen driver[1]. This is corroborated by the wiki[2].

Further, I can't find any info/datasheets on the GT1158.

  1. https://gitlab.com/pine64-org/linux/-/blob/cbaae8db31215ed315a8e3f66a075c278a5777ea/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts#L827
  2. https://gitlab.com/pine64-org/linux/-/blob/cbaae8db31215ed315a8e3f66a075c278a5777ea/drivers/input/touchscreen/goodix.c#L100
  3. https://wiki.pine64.org/wiki/PinePhone_Pro#Components
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: pine64-remove-gt1158