Skip to content

Draft: Revert "input: touchscreen: goodix: Add support for GT1158"

Tom requested to merge tomfitzhenry/linux:pine64-remove-gt1158 into pine64-kernel-ppp-5.16.y
  • Marked as Draft until I test this.

This reverts commit 0dd4edb5.

Ideally we'd just remove this commit from the fork. What's a good workflow for this?

Per the DTS[0], PinePhone Pro does not use GT1158. Rather, it uses gt917s which is in the goodix touchscreen driver[1]. This is corroborated by the wiki[2].

Further, I can't find any info/datasheets on the GT1158.

  1. https://gitlab.com/pine64-org/linux/-/blob/cbaae8db31215ed315a8e3f66a075c278a5777ea/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts#L827
  2. https://gitlab.com/pine64-org/linux/-/blob/cbaae8db31215ed315a8e3f66a075c278a5777ea/drivers/input/touchscreen/goodix.c#L100
  3. https://wiki.pine64.org/wiki/PinePhone_Pro#Components

Merge request reports