Item in some menus can't doesn't have function
Description
In some menus, we can place items without function (it's very usefull for décoration or information). But in these menu, we can't, the menu doesn't open and an error is displayed un console or items are not displayed.
Here are the menus concerned :
- action
- confirmation
- contract-middleman
- contract-portfolio
- proposal
- contract-type
- proposal-creation
How to reproduce
- Create an item without function in one of these menus
- Reload config
- Try to open this menu
Informations
Plugin version : 1.2.6
Annex
The error :
[17:28:27 ERROR]: Could not pass event InventoryClickEvent to Contracts v1.6.2
java.lang.NullPointerException: Cannot invoke "fr.phoenix.contracts.gui.objects.item.InventoryItem.getFunction()" because "<local3>" is null
at fr.phoenix.contracts.gui.objects.EditableInventory.getByFunction(EditableInventory.java:68) ~[Contracts-1.6.2.jar:?]
at fr.phoenix.contracts.gui.ContractMiddlemanViewer$ContractMiddlemanInventory.<init>(ContractMiddlemanViewer.java:302) ~[Contracts-1.6.2.jar:?]
at fr.phoenix.contracts.gui.ContractMiddlemanViewer.generate(ContractMiddlemanViewer.java:47) ~[Contracts-1.6.2.jar:?]
at fr.phoenix.contracts.gui.ContractsViewer$ContractsGenerated.whenClicked(ContractsViewer.java:70) ~[Contracts-1.6.2.jar:?]
at fr.phoenix.contracts.gui.objects.GeneratedInventory.whenClicked(GeneratedInventory.java:134) ~[Contracts-1.6.2.jar:?]
at fr.phoenix.contracts.listener.PlayerListener.b(PlayerListener.java:51) ~[Contracts-1.6.2.jar:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1158.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:git-Paper-307]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.20.2.jar:git-Paper-307]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.20.2.jar:git-Paper-307]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3108) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23) ~[?:?]
at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:53) ~[?:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1324) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:193) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1301) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1294) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1272) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1160) ~[paper-1.20.2.jar:git-Paper-307]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-307]
at java.lang.Thread.run(Thread.java:840) ~[?:?]