Skip to content

modifying ntrdc to remove inner iteration convergence check and allow the...

Heeho Park requested to merge pakodot/petsc-2:heeho/ntrdc-fix into main

I am modifying ntrdc to remove the inner iteration external convergence check and allow the algorithm to check the validity. There are cases where the convergence check used to be satisfied with infinity norm criteria if the trust region was truncated enough but not enough to be too small (to cut the time step).

# -------------
#   Summary    
# -------------
# success 9414/11917 tests (79.0%)
# failed 0/11917 tests (0.0%)
# todo 243/11917 tests (2.0%)
# skip 2260/11917 tests (19.0%)
#
# Wall clock time for tests: 4804 sec
# Approximate CPU time (not incl. build time): 2728.5999999999844 sec
#
# Timing summary (actual test time / total CPU time): 
#   dm_impls_swarm_tests-ex5_bsi_2d_mesh_1_par_4: 82.14 sec / 131.91 sec
#   tao_constrained_tutorials-ex1_5: 58.20 sec / 58.26 sec
#   dm_impls_swarm_tests-ex5_bsi_2d_mesh_1_par_3: 37.67 sec / 61.95 sec
#   ts_tutorials-ex18_p1p1_xper_ref: 36.66 sec / 36.72 sec
#   ts_tutorials-ex26_2: 32.98 sec / 50.20 sec

The act of submitting a merge request will be understood as an affirmation of the Developer’s Certificate of Origin 1.1 at https://petsc.org/release/install/license/

See https://petsc.org/release/developers/integration/ for instructions on preparing and submitting a merge request. If the merge request is not from a fork, then you must

  • List yourself as assignee
  • List one or more reviewers
  • Select labels including liking workflow::Review

For merge request from a fork

  • make sure the fork is not private - gitlab MR process (pipelines, merge) breaks with it.
  • cc: one of the developers in the MR description who can shepherd the MR

Merge request reports