Skip to content

Fix compiler warnings when using revolve with 64bit indices

Hong Zhang requested to merge hongzh/fix-64bit-revolve into release

Revolve is tied to int32, thus giving compiler warnings when PETSc is configured with int64.

{PETSCDIR PATH REMOVED}/src/ts/trajectory/impls/memory/trajmemory.c:1479:130: warning: incompatible pointer types passing 'PetscInt *' (aka 'long long *') to parameter of type 'int *' [-Wincompatible-pointer-types]
    whattodo = revolve_action(&tjsch->rctx->check,&tjsch->rctx->capo,&tjsch->rctx->fine,tjsch->rctx->snaps_in,&tjsch->rctx->info,&tjsch->rctx->where); /* must return 1 or 3 or 4*/
                                                                                                                                 ^~~~~~~~~~~~~~~~~~~
{PETSCDIR PATH REMOVED}/lib/include/revolve_c.h:14:49: note: passing argument to parameter here
int  revolve_action(int*,int*,int*,int,int*,int*);

Commit-type: bug-fix /spend 2h Reported-by: Anton Glazkov anton.glazkov@chch.ox.ac.uk

Edited by Hong Zhang

Merge request reports