• Jeff King's avatar
    xdiff: use xmalloc/xrealloc · 36c83197
    Jeff King authored
    Most of xdiff uses a bare malloc() to allocate memory, and returns an
    error when we get NULL. However, there are a few spots which don't check
    the return value and may segfault, including at least xdl_merge() and
    xpatience.c's find_longest_common_sequence().
    
    Let's use xmalloc() everywhere instead, so that we get a graceful die()
    for these cases, without having to do further auditing. This does mean
    the existing cases which check errors will now die() instead of
    returning an error up the stack. But:
    
      - that's how the rest of Git behaves already for malloc errors
    
      - all of the callers of xdi_diff(), etc, die upon seeing an error
    
    So while we might one day want to fully lib-ify the diff code and make
    it possible to use as part of a long-running process, we're not close to
    that now. And because we're just tweaking the xdl_malloc() macro here,
    we're not really moving ourselves any further away from that. We
    could, for example, simplify some of the functions which handle malloc()
    errors which can no longer occur. But that would probably be taking us
    in the wrong direction.
    
    This also makes our malloc handling more consistent with the rest of
    Git, including enforcing GIT_ALLOC_LIMIT and trying to reclaim pack
    memory when needed.
    Reported-by: 's avatar王健强 <jianqiang.wang@securitygossip.com>
    Signed-off-by: 's avatarJeff King <peff@peff.net>
    Signed-off-by: 's avatarJunio C Hamano <gitster@pobox.com>
    36c83197
Name
Last commit
Last update
..
xdiff.h Loading commit data...
xdiffi.c Loading commit data...
xdiffi.h Loading commit data...
xemit.c Loading commit data...
xemit.h Loading commit data...
xhistogram.c Loading commit data...
xinclude.h Loading commit data...
xmacros.h Loading commit data...
xmerge.c Loading commit data...
xpatience.c Loading commit data...
xprepare.c Loading commit data...
xprepare.h Loading commit data...
xtypes.h Loading commit data...
xutils.c Loading commit data...
xutils.h Loading commit data...