Skip to content
  • Jonathan Tan's avatar
    http, imap-send: stop using CURLOPT_VERBOSE · 7167a62b
    Jonathan Tan authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    Whenever GIT_CURL_VERBOSE is set, teach Git to behave as if
    GIT_TRACE_CURL=1 and GIT_TRACE_CURL_NO_DATA=1 is set, instead of setting
    CURLOPT_VERBOSE.
    
    This is to prevent inadvertent revelation of sensitive data. In
    particular, GIT_CURL_VERBOSE redacts neither the "Authorization" header
    nor any cookies specified by GIT_REDACT_COOKIES.
    
    Unifying the tracing mechanism also has the future benefit that any
    improvements to the tracing mechanism will benefit both users of
    GIT_CURL_VERBOSE and GIT_TRACE_CURL, and we do not need to remember to
    implement any improvement twice.
    
    Signed-off-by: default avatarJonathan Tan <jonathantanmy@google.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    7167a62b