Skip to content
  • Jay Soffian's avatar
    Teach commit about CHERRY_PICK_HEAD · 37f7a857
    Jay Soffian authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    Previously the user was advised to use commit -c CHERRY_PICK_HEAD after
    a conflicting cherry-pick. While this would preserve the original
    commit's authorship, it would sadly discard cherry-pick's carefully
    crafted MERGE_MSG (which contains the list of conflicts as well as the
    original commit-id in the case of cherry-pick -x).
    
    On the other hand, if a bare 'commit' were performed, it would preserve
    the MERGE_MSG while resetting the authorship.
    
    In other words, there was no way to simultaneously take the authorship
    from CHERRY_PICK_HEAD and the commit message from MERGE_MSG.
    
    This change fixes that situation. A bare 'commit' will now take the
    authorship from CHERRY_PICK_HEAD and the commit message from MERGE_MSG.
    If the user wishes to reset authorship, that must now be done explicitly
    via --reset-author.
    
    A side-benefit of passing commit authorship along this way is that we
    can eliminate redundant authorship parsing code from revert.c.
    
    (Also removed an unused include from revert.c)
    
    Signed-off-by: default avatarJay Soffian <jaysoffian@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    37f7a857