Skip to content
  • Jeff King's avatar
    t1300: document some aesthetic failures of the config editor · 53ca053b
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    The config-editing code used by "git config var value" is
    built around the regular config callback parser, whose only
    triggerable item is an actual key. As a result, it does not
    know anything about section headers, which can result in
    unnecessarily ugly output:
    
      1. When we delete the last key in a section, we should be
         able to delete the section header.
    
      2. When we add a key into a section, we should be able to
         reuse the same section header, even if that section did
         not have any keys in it already.
    
    Unfortunately, fixing these is not trivial with the current
    code. It would involve the config parser recording and
    passing back information on each item it finds, including
    headers, keys, and even comments (or even better, generating
    an actual in-memory parse-tree).
    
    Since these behaviors do not cause any functional problems
    (i.e., the resulting config parses as expected, it is just
    uglier than one would like), fixing them can wait until
    somebody feels like substantially refactoring the parsing
    code. In the meantime, let's document them as known issues
    with some tests.
    
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    53ca053b