Skip to content
  • Karsten Blees's avatar
    pack-bitmap: do not use gcc packed attribute · b5007211
    Karsten Blees authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    The "__attribute__" flag may be a noop on some compilers.
    That's OK as long as the code is correct without the
    attribute, but in this case it is not. We would typically
    end up with a struct that is 2 bytes too long due to struct
    padding, breaking both reading and writing of bitmaps.
    
    Instead of marshalling the data in a struct, let's just
    provide helpers for reading and writing the appropriate
    types. Besides being correct on all platforms, the result is
    more efficient and simpler to read.
    
    Signed-off-by: default avatarKarsten Blees <blees@dcon.de>
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    b5007211