Skip to content
  • Brandon Casey's avatar
    xdiff-interface.c: strip newline (and cr) from line before pattern matching · a5a5a048
    Brandon Casey authored
    
    
    POSIX doth sayeth:
    
       "In the regular expression processing described in IEEE Std 1003.1-2001,
        the <newline> is regarded as an ordinary character and both a period and
        a non-matching list can match one. ... Those utilities (like grep) that
        do not allow <newline>s to match are responsible for eliminating any
        <newline> from strings before matching against the RE."
    
    Thus far git has not been removing the trailing newline from strings matched
    against regular expression patterns. This has the effect that (quoting
    Jonathan del Strother) "... a line containing just 'FUNCNAME' (terminated by
    a newline) will be matched by the pattern '^(FUNCNAME.$)' but not
    '^(FUNCNAME$)'", and more simply not '^FUNCNAME$'.
    
    Signed-off-by: default avatarBrandon Casey <casey@nrlssc.navy.mil>
    Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
    a5a5a048