Skip to content
  • Jonathan Tan's avatar
    upload-pack: send refs' objects despite "filter" · a0c9016a
    Jonathan Tan authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    A filter line in a request to upload-pack filters out objects regardless
    of whether they are directly referenced by a "want" line or not. This
    means that cloning with "--filter=blob:none" (or another filter that
    excludes blobs) from a repository with at least one ref pointing to a
    blob (for example, the Git repository itself) results in output like the
    following:
    
        error: missing object referenced by 'refs/tags/junio-gpg-pub'
    
    and if that particular blob is not referenced by a fetched tree, the
    resulting clone fails fsck because there is no object from the remote to
    vouch that the missing object is a promisor object.
    
    Update both the protocol and the upload-pack implementation to include
    all explicitly specified "want" objects in the packfile regardless of
    the filter specification.
    
    Signed-off-by: default avatarJonathan Tan <jonathantanmy@google.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    a0c9016a