Skip to content
  • Ævar Arnfjörð Bjarmason's avatar
    cvs tests: skip tests that call "cvs commit" when running as root · a78d9258
    Ævar Arnfjörð Bjarmason authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    Change the tests that fail to when we run the test suite as root, due
    to calling "cvs commit".
    
    The GNU cvs package has an optional compile-time CVS_BADROOT
    flag. When compiled with this flag "cvs commit" will refuse to commit
    anything as root. On my Debian box this isn't compiled in[1] in, but
    on CentOS it is.
    
    I've run all the t/t*cvs*.sh tests, and these are the only two that
    fail. For some reason e.g. t9402-git-cvsserver-refs.sh still works as
    root despite doing "cvs commit", I haven't dug into why.
    
    This commit is technically being overzealous, we could do better by
    making a mock cvs commit as root and run the tests if that works, but
    I don't see any compelling reason to bend over backwards to run these
    tests in all cases, just skipping them as root seems good enough.
    
    1. Per: strings /usr/bin/cvs|grep 'is not allowed to commit'
       Using cvs 1.11.23 on CentOS, 1.12.13-MirDebian-18 on Debian.
    
    Signed-off-by: default avatarÆvar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    a78d9258