Skip to content
  • Kyle Meyer's avatar
    delete_ref: accept a reflog message argument · 755b49ae
    Kyle Meyer authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    When the current branch is renamed with 'git branch -m/-M' or deleted
    with 'git update-ref -m<msg> -d', the event is recorded in HEAD's log
    with an empty message.  In preparation for adding a more meaningful
    message to HEAD's log in these cases, update delete_ref() to take a
    message argument and pass it along to ref_transaction_delete().
    Modify all callers to pass NULL for the new message argument; no
    change in behavior is intended.
    
    Note that this is relevant for HEAD's log but not for the deleted
    ref's log, which is currently deleted along with the ref.  Even if it
    were not, an entry for the deletion wouldn't be present in the deleted
    ref's log.  files_transaction_commit() writes to the log if
    REF_NEEDS_COMMIT or REF_LOG_ONLY are set, but lock_ref_for_update()
    doesn't set REF_NEEDS_COMMIT for the deleted ref because REF_DELETING
    is set.  In contrast, the update for HEAD has REF_LOG_ONLY set by
    split_head_update(), resulting in the deletion being logged.
    
    Signed-off-by: Kyle Meyer's avatarKyle Meyer <kyle@kyleam.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    755b49ae