Skip to content
  • Dmitry Ivankov's avatar
    fast-import: count and report # of calls to diff_delta in stats · 94c3b482
    Dmitry Ivankov authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    It's an interesting number, how often do we try to deltify each type of
    objects and how often do we succeed. So do add it to stats.
    
    Success doesn't mean much gain in pack size though. As we allow delta to
    be as big as (data.len - 20). And delta close to data.len gains nothing
    compared to no delta at all even after zlib compression (delta is pretty
    much the same as data, just with few modifications).
    
    We should try to make less attempts that result in huge deltas as these
    consume more cpu than trivial small deltas. Either by choosing a better
    delta base or reducing delta size upper bound or doing less delta attempts
    at all.
    
    Currently, delta base for blobs is a waste literally. Each blob delta
    base is chosen as a previously stored blob. Disabling deltas for blobs
    doesn't increase pack size and reduce import time, or at least doesn't
    increase time for all fast-import streams I've tried.
    
    Signed-off-by: default avatarDmitry Ivankov <divanorama@gmail.com>
    Acked-by: default avatarDavid Barr <davidbarr@google.com>
    Acked-by: default avatarJonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    94c3b482