Skip to content
  • SZEDER Gábor's avatar
    Make error message after failing commit_lock_file() less confusing · 08a3651f
    SZEDER Gábor authored
    
    
    The error message after a failing commit_lock_file() call sometimes
    looks like this, causing confusion:
    
      $ git remote add remote git@server.com/repo.git
      error: could not commit config file .git/config
      # Huh?!
      # I didn't want to commit anything, especially not my config file!
    
    While in the narrow context of the lockfile module using the verb
    'commit' in the error message makes perfect sense, in the broader
    context of git the word 'commit' already has a very specific meaning,
    hence the confusion.
    
    Reword these error messages to say "could not write" instead of "could
    not commit".
    
    While at it, include strerror in the error messages after writing the
    config file or the credential store fails to provide some information
    about the cause of the failure, and update the style of the error
    message after writing the reflog fails to match surrounding error
    messages (i.e. no '' around the pathname and no () around the error
    description).
    
    Signed-off-by: default avatarSZEDER Gábor <szeder@ira.uka.de>
    Signed-off-by: default avatarJeff King <peff@peff.net>
    08a3651f