Remove status icons from form control components
Created by: mcoker
The problem with those icons, since they are background images to browser rendered form elements:
- https://github.com/patternfly/patternfly/issues/2702 - browsers stomp on custom background styles for these elements in ways we can't override
- https://github.com/patternfly/patternfly/issues/4652 - content security policies disallow data URIs as the source for images in markup
- https://github.com/patternfly/patternfly/issues/4900 - due to the way we import sass vars, the default/light theme form control icon is the wrong color currently.
Met with the team and we decided the icon in the form control component should be moved out of that element and into the helper text instead. This update should remove the use of background images from the form control component.
- The exception here may be the form select arrow, since it is also created from a FA icon as a background image. I think we should remove it and get away from trying to style that directly on a browser rendered element until there is better support for customizing these elements, or we suggest the use of our select component.
Related: Here's the core issue for updating the helper text component - https://github.com/patternfly/patternfly/issues/5438 And the related react issue - https://github.com/patternfly/patternfly-react/issues/8863