Spike - Modal - support for height variations
Created by: mcoker
With the wizard and about modal now as children of the modal component, they both have custom heights that we might reconsider in general and whether they belong on the individual components, or if it's a shared concept we could move to the modal.
About modal
- Small screens - height (and width) is 100%. It occupies the entire viewport without any padding or anything.
- Large screens - 762px with a max-height of 100% of the viewport height minus the "xl" spacer's value (to give padding above/below the about modal so it doesn't touch the top/bottom of the viewport)
Wizard
- Small screens - height is 762px
- Large screens - height is 762px
The modal component has width variations, but not height variations, with the exception of both a max-height and max-width of whatever the viewport size is with a little padding on the top/bottom. Currently any sort of min/max height on the content of the wizard will need to come from the content or be manually set on the wizard as a custom override.
However now that we have 2 components that live in the wizard that have a common min-height, that says we may have a pattern worth supporting in the modal instead of one-off code in the components. I think my questions are:
- Do we need to impose any sort of default/min height on the wizard or about modal when placed in a modal? Or could the wizard and about modal just be as tall as the content inside of it? This would imply we don't need height variations on the modal just yet.
- If we are imposing default/min heights on wizard and about modal:
- Could we update them so that they're the same? They are the same on large screens how (762px), but on small screens the wizard is 762px and the about modal is 100% height of the viewport.
- Can this exist as a variation(s?) on the modal instead? Assuming so, do we have an idea of what those heights would be?
cc @mcarrano @mceledonia @mmenestr