Skip to content

A stray ) caused the secret effects to stop working

David Burke requested to merge fix-get-secrets-effect into staging

@BrendanBerkley this is what caused funkiness when you wiped the auth tokens. It should work fine now without reloading.

@nliles remember when I didn't understand why I needed a | in the marbles test? | means "The successful completion of an observable." Well that should have been a red flag that something was wrong! The effect had a bad ) which closed it before I intended it to close (as seen by whitespace). This had some strange effects where if the effect ever got the APIError it would just close and never work again.

I made two tests to cover it. I don't think the second added test is needed for every api call effect - but it was interesting to learn how to send multiple mocked responses from the service. Turns out the marbles tests can be useful - but only once you understand it's insane syntax and crap documentation.

Merge request reports