Skip to content

Attempt to add NS new secret form into monorepo

Brendan Berkley requested to merge brendan-tries-ns-work into dev

Part of ongoing work to merge passit-mobile and passit-frontend. Works with new secret form, and I also fixed the margin issues in the login component.

Notes:

  1. Currently doesn't work, but it's close. If I remove all [ngrxFormControlState] bits from secret-form.component.tns.html, it will load the form.
  2. If I leave that in (as is the case in this MR), I get an error like JS: ERROR Error: Uncaught (in promise): Error: No valid view adapter!
  3. Porting secret-form.component.tns.ts required some changes:
    • apparently a bunch of imports like utils/utils needs to have tns-core-modules/ prepended
    • some path changes like for passit_sdk. No big deal
    • line 93: results required a type. any might be lazy but the confirm thing on the same line got the any treatment as well
    • that IS_TABLET from a constants file. Wasn't sure what to do with it. We already had a constants file where passit-mobile had one, and I didn't know if we wanted to do constants.tns.ts in that case. Since IS_TABLET is used only in secret form, figured it wouldn't hurt to have it here for now. But I am curious if it should be named constants.tns.ts instead.

Merge request reports