Skip to content

Refactor secret form with ngrx-forms

David Burke requested to merge secret-form into staging

Notable changes

  • Using ngrx-forms when editing a secret form
  • secret form is now seperate from list and has it's own state and container
  • Refactored some reducers to match ngrx example-app style and fixed some type safety issues (removed use of any in some reducers)
  • Using a integration tests now - but needs more.

Things to review

  • Does it work? Any bugs?
  • Is there more I could remove from list? Any dead code?

Wut

  • "Creates a secret and adds a group" test makes 0 sense. app.passit.io is set so that when you hit save the form stays open. Ok. This test ensures that the form closes! What? And that passed before? 😑
Edited by David Burke

Merge request reports

Loading