Skip to content

Resolve "Loading states"

David Burke requested to merge 72-load-state into staging

Closes #72 (closed)

This is two minor changes

  • It shows a loading... div instead of just blank. Just blank looks a little broken to me so I thought loading... is better than nothing. Maybe some day make a spinner.
  • The group page shows onboarding too for a second. At first I thought we needed to do a isFirstLoadComplete state like for list. BUT groups are loaded in when secrets are. So why would clicking groups not have groups already loaded? Turns out the form reset action was resetting a bit too much state in the group reducer. I just modified that as made a test to show why.

I think you might still see something odd if you go to the groups route directly - but that's really an edge case. I don't think it's even possible until we implement login route redirects. Right now going to /groups would just make you log in and go to /list. I think this is a minimally invasive improvement and worth merging as is.

So things to review

  • Does my plan make sense overall?
  • Is my loading div good enough? ie it's an improvement and not super ugly or disagreeable.
  • Does my reducer change + spec make sense?

Merge request reports