Skip to content

Refactor `BaseDialogComponent` for l10n

Lukas Weingarten requested to merge 1180-adjust-dialog-service-to-l10n-scope-related-changes into master

Stop using section as a scope for input strings and just use the variables instead.

Remove unnecessary aria labels for confirm and cancel buttons which are currently broken if the component isn't used for deletion.

Return undefined if dialog action has been cancelled to simplify result checks in afterClosed subscriptions.

Adjust components and services which are using base dialog component: Always provide scope for translation strings and adjust for updated return value in afterClosed subscriptions.

Also move i18n strings to correct scope and remove no longer needed a11y i18n strings.

Closes #1180 (closed)

Merge request reports