Skip to content

Refactor comment components

Lukas Weingarten requested to merge 1079-refactor-q-a-feature-components into master

Create comment modules for participant, creator and presentation. For this create AbstractCommentsPageComponent which contains code shared by all comment page components.

For this split the old CommentListComponent and CommentPageComponent into smaller standalone components as CommentListBarComponent for example. Also create role specific module components as CommentListBarExtensionComponent for example.

Furthermore cleanup components in this course and simplify and refactor component logic. Move functions to CommentService and get rid of styling variables in component classes as deviceType or deviceWidth and move logic to SCSS files instead. Also make use of [attr.aria-label] instead of creating visually hidden divs for a11y.

Stop use of DialogActionButtonComponent and and remove the component since it's no longer used at all. Also stop using DialogService.

Create classes and enums for cross component models.

Move components to according role comment module and make shared components standalone.

For now, the comment view in the answer dialog view has been simplified to prevent circular dependencies (detected with Storybook). This component needs to revised anyway.

Closes #1086 (closed)

Depends on !1687 (merged)

Edited by Lukas Weingarten

Merge request reports