Skip to content

feat: export rollup types

Victor Berchetrequested to merge
github/fork/vicb/rollup/type into main

Description

I have been working on the vite plugin in Nx.

We use the vite API to call build

https://github.com/nrwl/nx/blob/9cc2be61066c9281db229fb2b0ee72a2d153b2ee/packages/vite/src/executors/build/build.impl.ts#L75-L79

When watch mode is enabled buid() returns a RollupWatcher emitting RollupWatcherEvent

I can not add types in the code because import { RollupWatcher, RollupWatcherEvent } from 'rollup'; import from the rollup package installed by Nx which is not compatible with the rollup version used by vite.

With this change I could import { RollupWatcher, RollupWatcherEvent } from 'vite'; and add those types to the code.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Merge request reports