Skip to content

Small fix to "reset_nginx" function in "osp-config.sh"

Merge Request Guidelines

  1. Please fill this form out to the best of your ability.
  2. Follow the principle of "One Merge Request, One Concern"
  3. Merge Requests must be complete in total.
  4. Contributed Code must be universal in scope, ie: Able to be used for all installs / install environments.

Description

reset_neginx
    ...
    sudo systemctl stop nginx-osp
    sudo systemctl start nginx-osp

I noticed that one of the final lines is sudo systemctl stop nginx-osp when it should be 'enable nginx-osp', since it was disabled at the start of the function.

Motivation and Context

Mostly to fix a small mistake and ensure that the auto-start for nginx-osp is re-enabled, to avoid issues down the line.

How Has This Been Tested?

This was tested on a test instance of an OSP site. To confirm that the auto-start for nginx-osp is enabled after the completion of the nginx reset procedure, systemctl is-enabled nginx-osp is used, and it does output 'enabled' in this case.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • Merge Request Follows the Merge Request Guidelines
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Merge request reports