Skip to content

Fix OTP + "Remember Me" 500 Error

Stefan Kern requested to merge (removed):build/0.9.x into master

Merge Request Guidelines

  1. Please fill this form out to the best of your ability.
  2. Follow the principle of "One Merge Request, One Concern"
  3. Merge Requests must be complete in total.
  4. Contributed Code must be universal in scope, ie: Able to be used for all installs / install environments.

Description

Fixes a bug where using OTP and the "Remember Me" checkbox at the same time resulted in a 500 Error due to "1 week" in app.py not being correct and thus failing to properly set the Cookie Expiration date. In reality it'd be "1 weeks" however I changed it to "7 days" as it's doing exactly the same and looks grammatically better too.
This time the right branch :)

Motivation and Context

Fixes a 500 Error when "Remember Me" and OTP is used at the same time.

How Has This Been Tested?

Edited the app.py and restarted the server, then tested the changes. After the change to both "1 weeks" and "7 days" the error was fixed and the Cookie expiration time was properly set again (Checked via Cookie Editor Add-On for Edge).

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • Merge Request Follows the Merge Request Guidelines
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Merge request reports