Skip to content

feat: set all container IP's to localhost on windows

Jon Foss Mikalsen requested to merge windows-container-ip into master

Currently, Windows does not resolve Docker IP addresses when your not inside a container. As a result all the container IPs retrieved within the test body on Windows does not resolve.

Our current workaround is the following:

let container_ip = if cfg!(windows) {
    127.0.0.1
} else {
    container_handle.ip()
};

As this gets pretty tedious and annoying i suggest simply setting the IP of containers to 127.0.0.1 if we are on Windows. A drawback with this approach is that CI/CD on a Windows host with a Docker executor will not work, but I suspect it already doesn't as it hasn't been tested.

With this change no special handling is required from a user when retrieving container IP's based on which platform he/she is running on.

Merge request reports