Skip to content

Draft: PoC: Allow specifying a "club" for lifters - similar to their IG

Simon Oswald requested to merge Osslack/opl-data:main into main

Hi,

Based on my rough idea as described in #14685 (closed) - I just mainly brute-force looked at what you did to get the instagram-thing going and added a corresponding thing for the PL club.

This is just a first step/PoC, I would envision:

  • Make the PL club searchable, currently it only finds it when I search for "2018", not "Mannheim" or similar
  • A "club ranking", where all lifters with the same club are listed
  • Maybe on the club-page allow linking to the clubs instagram

But I see those things as cool add-ons for the future.

For now, I think the main thing missing is testing - I am not sure where and how your tests are structured. I saw one for the instagram stuff, but I currently have tomatoes on my eyes and can't find it...

Also missing is the whole "process-thing", i.e. describe how to add your club, the email templates etc - thats something I will still do once the general direction of this PR is fine with you 😄

Some screenshots to show what it looks like currently:

On the detailed athlete page:

Screenshot_from_2023-03-03_17-38-48

In the overall ranking:

Screenshot_from_2023-03-03_17-39-03

Edited by Simon Oswald

Merge request reports