Skip to content

Simplify the logic used to create the band tool holder and place the arms during render

Julian Stirlingrequested to merge
simplify-band-tool-logic into band-stretch-on-insertion

This removes the issue found in !508 (merged) that the position of the holes for the arms is set not by the translation but by a translation plus a scaling.

Logically the spacing we we want is radius of the column + height of the tool +2 for the width of the band. What have in code before is (radius+1.14+h)*1.1 where the 1.1 is from scaling.

If we calculate this is the same as doing radius+h+2.026. The new code uses 2mm so the position of the tool is shifted 26 microns. The outer shape of the holder is very minimally different but this should be backwards compatible as the outer shape is for holding.

The renders will have changed slightly. The assembly in scad looks fine to me locally. Interested in other opinions once CI completes.

Merge request reports