Skip to content

Stop reading scan_data.json for ongoing scan.

Julian Stirlingrequested to merge
ongoing-scan-data-warning into v3

When the scan tab refreshes and gets information about the scans it doesn't read the json data of a scan if it is ongoing.

Closes #583

This MR contains the following

  • Rename ScanListData to ScanListInfo as it contains ScanInfo not ScanData objects. This is due to the confusion of scan data (from the JSON file) vs scan info (what we send to the UI)
  • Pass the ongoing scan name to the directory manager when collecting scan information
  • Directory manager doesn't read the scan_data.json for the ongoing scan
  • UI reports "Ongoing" rather than "Not known" if the scan is ongoing
  • Change Duration and Created to start with capitals.

UI changes

Before:
Screenshot_20251029_092527

After:
Screenshot_20251029_092546

Merge checklist:

  • All new/changed functions have up to date typehints and docstrings
  • Any UI updates have a before and after screenshot in the MR description
  • Unit testing of new functionality has similar or better coverage than similar existing code
  • This code has been tested on a microscope
    • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
    • With updated settings JSON (if changed)
    • SmartScan and live stitching work
Edited by Julian Stirling

Merge request reports