Skip to content

Draft: Make calibration modal less confusing

Chish36requested to merge
cal_modal_less_confusing into v3

This MR separates the show method into a check calibration and show method so that we can dynamically check the state of calibration. The menu navigation buttons should dynamically update between skip and next after running full auto calibrate for either LST or CSM. The modal will always show next when the calibration modal is opened manually at the click of a button.

Closes #403

This MR contains the following

  • Dynamic button labelling for menu navigation

Things to do before merge:

  • Ensure that the calibration modal opens at the appropriate times
  • Make sure the check_calibration function runs when it should (i.e. on startup and when full-auto calibrate is ran).

Merge checklist:

  • All new/changed functions have up to date typehints and docstrings
  • Any UI updates have a before and after screenshot in the MR description
  • Unit testing of new functionality has similar or better coverage than similar existing code
  • This code has been tested on a microscope
    • With webapp has been recompiled (if changed)
    • With updated settings JSON (if changed)
    • SmartScan and live stitching work

Merge request reports