Skip to content

fix: Accidental early return on zoom account loop.

This pull request fixes a bug in the zoom migration code where only the first zoom account might be honored due to an early return.

JIRA tickets: https://tasks.opencraft.com/browse/STAR-4062

Testing instructions:

  1. make install_prereqs
  2. Copy all the CI variables locally in an .env file (not because .env is respected but because it isn't tracked by source control) in this manner:
export GOOGLE_API_CREDENTIALS=$(
cat <<'END_HEREDOC'
{
  "creds_or_token": {"token": "token-here", "refresh_token": "refresh-token-here", "token_uri": "https://oauth2.googleapis.com/token", "client_id": "client-id-here", "client_secret": "secret-here", "scopes": ["https://www.googleapis.com/auth/drive.file", "https://www.googleapis.com/auth/drive.metadata"], "expiry": "expiry-date"},
  "scopes": ["https://www.googleapis.com/auth/drive.file", "https://www.googleapis.com/auth/drive.metadata"]
}
END_HEREDOC
)
  1. source .env to load the CI variables (make sure you set them all)
  2. Add print statements to verify the loop
  3. Comment out the email line, since the firewall will prevent this, apparently
  4. make migrate_zoom_meetings
  5. Once verified, delete the .env file

Preferably, if you have access to some, use test credentials instead of the real CI ones. Or trust me bro, it's a one line obvious fix. How broken could it be?

Edited by Fox Danger Piacenti

Merge request reports

Loading