Skip to content

fix: Numeric type to fill the answer one click

Farhaan Bukhsh requested to merge farhaan/bb-6585-fix-numeric-submission into master

The changes are added to have validation error in case numeric has min greater than or equal to max. The UI changes here is to make sure value is updated only on the click of the increase or decrease button.

Supporting information

Discussions

Link to any public discussions about this PR or the design/architecture. Otherwise omit this.

Dependencies

None or link it here.

Visual changes

listaflow-dev

listflow-backend

Merge deadline

"None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions

Step by step procedure

  1. Get the devstack working
  2. Now once you make a checklist which has numeric type
  3. Go to the checklist and try increasing the number using the button, you will see on first click the checklist progress is not updated.
  4. Go to the numeric checklist on Django admin have max value less than minimum value, you would be able to submit it.
  5. Now pull in the branch and try the above tests, on click of the button the form progress will be updated and there will be validation error raised once you input wrong values.

Author notes and concerns

None or note it here

Edited by Farhaan Bukhsh

Merge request reports