Skip to content

[STAR-4135] Sidebar fixes

Fox Danger Piacentirequested to merge
fox/sidebar-fix into master

This MR fixes an issue where attempting to view an incompleted, one-off checklist from another team member would break the UI.

This MR also changes the behavior of read-only checklists to display the checklist if any amount of it has been completed, but display a warning on top that the checklist is still in progress if it has not been marked as completed. This allows team members to see what things have already been completed in the case that a checklist was not fully finished (I.E., the last steps of the vacation checklist weren't ticked before taking off.)

Supporting information

Visual changes

One-off checklist that has no progress and isn't submitted:

image

One-off checklist which hasn't been completed but has some progress:

image

Recurrence-run checklist that has no progress and isn't submitted:

image

One-off checklist which hasn't been completed but has some progress:

image

Dependencies

!161 (merged)

Testing instructions

Step by step procedure

  1. make
  2. Create a one-off checklist and use another team member to view the URL.
  3. Complete a task on that checklist
  4. Check with the other user again. See that the in-progress read-only checklist renders.
  5. Complete the checklist. Verify that it shows a completed read-only checklist for the other user.
  6. Create a recurrence and start a run. View another user's checklist. Verify that it prompts you to remind them.
  7. Complete a task on that checklist. View it again and verify it's sane and you can remind them.
  8. Complete the checklist. Verify it shows read-only without prompting for a reminder.

Merge request reports