Skip to content

fix: Enable adding multiple new checklist task definitions dynamically in Admin page

Sathis requested to merge sathis/short-code-admin-duplication into master

Existing admin creation views for inline checklist task definitions has two issues when adding new task definitions dynamically

  1. The JSONSchemaEditor will not work in dynamically added rows
  2. ID column value is repeated and when saving violates the primary key constraint.

Both of these issues are resolved by this MR.

Supporting information

  • Jira ticket: Url
  • GitLab issue: url

Discussions

None

Dependencies

short_stuff (https://github.com/Artconomy/short_stuff/).

Visual changes

ID field in Checklist Task Definition is made readonly.

Before Change: image

After Change: image

Merge deadline

"None".

Testing instructions

Step by step procedure

  1. Login to Admin Page
  2. Click Add button in "Workflow" -> "Checklist definitions" on the left side panel.
  3. Create a Checklist definition and add Checklist task definitions.
  4. Add multiple checklist task definitions by clicking on "Add another Checklist task definition" button on bottom of "CHECKLIST TASK DEFINITIONS" sections.

Author notes and concerns

None

Edited by Sathis

Merge request reports