fix: ensure RDS creation does not prevent destroy
Description
This MR fixes terraform destroy using the AWS provider. The AWS clusters couldn't be destroyed cleanly as the final-rds-snapshot has a race condition.
The snapshot is created before the RDS is destroyed and terraform/AWS tries to create it twice upon destroy. By ignoring changes, we will create the snapshot, but not try to double-create it.
Supporting information
See the created snapshot here
Testing instructions
Steps to test the changes:
- Check that the snapshot is created
Dependencies
N/A
Screenshots
N/A
Checklist
If any of the items below is not applicable, do not remove them, but put a check in it.
-
All providers include the new feature/change -
All affected providers can provision new clusters -
Unit tests are added/updated -
Documentation is added/updated -
The TOOLS_CONTAINER_IMAGE_VERSION
in ci_vars.yml is updated -
The grove-template repository is updated
Additional context
N/A