Skip to content

fix: tutor sync failing issue due to hyphen in name

Kaustav Banerjee requested to merge kaustav/fix_tutor_sync_failing_for_hyphen_in_name into main

Description

Pre-deploy step was failing when instance name had hypen in it. Ex. test-combined

We fetch the terraform output as json, which contains S3 bucket names for tutor config, with the instance name as the key. We filter the correct bucket name from the json using jq -r .{instance_name} command. However this fails when there is hypen in the instance name. This MR fixes this by using addition quotes around the instance name.

Testing instructions

  1. Deploy instance with hyphen in it. Ex. test-combined. Verify pre-deploy step passes.
  2. Deploy instance without hyphen in it. Ex. testcomb. Verify pre-deploy step passes.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Merge request reports