Skip to content

Make instance deletion more robust (part of OC-1541)

Boros Gábor requested to merge pwr-delete into master

Created by: bradenmacdonald

I noticed that after my refactor in #63, it's possible to delete an OpenEdXInstance but leave behind an InstanceReference, or vice versa. The syntax for deleting all of an instance's VMs was also more complicated.

With this changeset, deleting either an Instance or an InstanceReference always deletes the other object (unless using bulk deletion through the ORM). Also, calling instance.delete() will delete the instance as well as the VMs of all of its appservers.

Author Concerns Is it too dangerous that one method can delete an instance and terminate all of its VMs?

Merge request reports