[SE-3619] improve notification emails
This PR makes sure that we send more verbose logs to be able to provide more context. Also, I found an additional issue with getting the previous app server, which is fixed by this PR too.
Screenshots: NA
Sandbox URL: N/A
Testing instructions:
- Checkout this code on stage environment
- Create an instance
- Enable periodic builds on the instance
- Add your email address to the Periodic build notification emails text field
- Set 00:05:00 as build interval (5 minutes)
- Misconfigure it to no be able to provision (for example change a database password or similar to have build logs and not fail immediately)
- Wait for the email (check your spam folder as well) - It should arrive in 5-10 minutes based on the delay in the queue
- Check the email has no sensitive data and has the desired (listed above) content.
- Check the email has a
build_log.json
attachment and it has content (with no secrets) - Check the email has a
configuration.json
attachment and it has content (with no secrets) - Fix the configuration
- Wait for the ack email - It should arrive in 5-10 minutes based on the delay in the queue
Author notes and concerns:
- I'll need to look for other improvements as well by checking the previously sent emails.
Reviewers