Skip to content

[SE-3619] improve notification emails

Boros Gábor requested to merge gabor/improve-notification-emails into master

This PR makes sure that we send more verbose logs to be able to provide more context. Also, I found an additional issue with getting the previous app server, which is fixed by this PR too.

Screenshots: NA

Sandbox URL: N/A

Testing instructions:

  1. Checkout this code on stage environment
  2. Create an instance
  3. Enable periodic builds on the instance
  4. Add your email address to the Periodic build notification emails text field
  5. Set 00:05:00 as build interval (5 minutes)
  6. Misconfigure it to no be able to provision (for example change a database password or similar to have build logs and not fail immediately)
  7. Wait for the email (check your spam folder as well) - It should arrive in 5-10 minutes based on the delay in the queue
  8. Check the email has no sensitive data and has the desired (listed above) content.
  9. Check the email has a build_log.json attachment and it has content (with no secrets)
  10. Check the email has a configuration.json attachment and it has content (with no secrets)
  11. Fix the configuration
  12. Wait for the ack email - It should arrive in 5-10 minutes based on the delay in the queue

Author notes and concerns:

  1. I'll need to look for other improvements as well by checking the previously sent emails.

Reviewers

Merge request reports