Skip to content

Fix migration that introduces instance states.

Boros Gábor requested to merge instance-states-fix-migrations into master

Created by: itsjeyd

Follows up on #57.

With the previous version of the migration, instance states were getting updated multiple times and ended up being set to Terminated if an instance had one or more servers with status Terminated associated with them.

Actual results when running migrations were:

Instance 66: Running, Server: Ready
Instance 71: Terminated, Server: Ready
Instance 79: Running, Server: Ready
Instance 90: Terminated, Server: Ready
Instance 104: Running, Server: Ready
Instance 126: Terminated, Server: Ready
Instance 127: Terminated, Server: Ready
Instance 146: Configuration failed, Server: Ready
Instance 170: Terminated, Server: Ready
Instance 172: Terminated, Server: Ready
Instance 176: Terminated, Server: Ready
Instance 177: Terminated, Server: Ready
Instance 178: Configuration failed, Server: Ready
Instance 179: Terminated, Server: Ready
Instance 181: Terminated, Server: Ready
Instance 182: Terminated, Server: Ready
Instance 183: Terminated, Server: Ready
Instance 186: Configuration failed, Server: Ready
Instance 187: Running, Server: Ready
Instance 188: Terminated, Server: Ready
Instance 189: Configuration failed, Server: Ready
Instance 190: Terminated, Server: Ready
Instance 191: Terminated, Server: Ready
Instance 192: Terminated, Server: Ready
Instance 193: Terminated, Server: Ready
Instance 196: Terminated, Server: Ready
Instance 197: Terminated, Server: Ready

Expected results:

Instance  66: Running, Server: Ready
Instance  71: Running, Server: Ready
Instance  79: Running, Server: Ready
Instance  90: Running, Server: Ready
Instance 104: Running, Server: Ready
Instance 126: ConfigurationFailed, Server: Ready
Instance 127: Running, Server: Ready
Instance 146: ConfigurationFailed, Server: Ready
Instance 170: Running, Server: Ready
Instance 172: Running, Server: Ready
Instance 176: Running, Server: Ready
Instance 177: Running, Server: Ready
Instance 178: ConfigurationFailed, Server: Ready
Instance 179: Running, Server: Ready
Instance 181: Running, Server: Ready
Instance 182: ConfigurationFailed, Server: Ready
Instance 183: Running, Server: Ready
Instance 186: ConfigurationFailed, Server: Ready
Instance 187: Running, Server: Ready
Instance 188: Running, Server: Ready
Instance 189: ConfigurationFailed, Server: Ready
Instance 190: Running, Server: Ready
Instance 191: ConfigurationFailed, Server: Ready
Instance 192: ConfigurationFailed, Server: Ready
Instance 193: ConfigurationFailed, Server: Ready
Instance 196: Running, Server: Ready
Instance 197: Running, Server: Ready

@open-craft/core Please do not deploy commits that are newer than 5319f4e2 before this gets merged.

Merge request reports